From b30f330262ca6593f445a40633780da2207d695d Mon Sep 17 00:00:00 2001
From: Clement Verna <cverna@tutanota.com>
Date: Jan 02 2017 20:08:57 +0000
Subject: Changed how we call the milestones property setter to save milestones imported from the git repository.

Fixes https://pagure.io/pagure/issue/1604

Signed-off-by: Clement Verna <cverna@tutanota.com>

---

diff --git a/pagure/lib/git.py b/pagure/lib/git.py
index 03fd140..81ece74 100644
--- a/pagure/lib/git.py
+++ b/pagure/lib/git.py
@@ -544,7 +544,9 @@ def update_ticket_from_git(
     if milestone:
         if milestone.strip() not in repo.milestones:
             try:
-                repo.milestones[milestone.strip()] = None
+                tmp_milestone = repo.milestones.copy()
+                tmp_milestone[milestone.strip()] = None
+                repo.milestones = tmp_milestone
                 session.add(repo)
                 session.commit()
             except SQLAlchemyError:
diff --git a/tests/test_pagure_lib_git.py b/tests/test_pagure_lib_git.py
index 265c83a..ff6e001 100644
--- a/tests/test_pagure_lib_git.py
+++ b/tests/test_pagure_lib_git.py
@@ -893,6 +893,7 @@ index 0000000..60f7480
             "content": "bar", "date_created": "1426500263",
             "user": {
                 "name": "pingou", "emails": ["pingou@fedoraproject.org"]},
+            "milestone": "Next Release",
         }
 
         self.assertRaises(
@@ -919,6 +920,8 @@ index 0000000..60f7480
         self.assertEqual(repo.issues[0].title, 'foo')
         self.assertEqual(repo.issues[0].depends_text, [])
         self.assertEqual(repo.issues[0].blocks_text, [])
+        self.assertEqual(repo.issues[0].milestone, 'Next Release')
+        self.assertEqual(repo.milestones, {'Next Release': None})
 
         data["title"] = "fake issue for tests"
         pagure.lib.git.update_ticket_from_git(
@@ -948,6 +951,7 @@ index 0000000..60f7480
             "blocks": [1],
             "depends": [3, 4],
             "date_created": "1426595224",
+            "milestone": "Future",
             "comments": [
                 {
                     "comment": "Nirik:\r\n\r\n- sourceforge++ \r\n- "
@@ -1000,6 +1004,8 @@ index 0000000..60f7480
         self.assertEqual(repo.issues[1].title, 'Rename pagure')
         self.assertEqual(repo.issues[1].depends_text, [])
         self.assertEqual(repo.issues[1].blocks_text, [1])
+        self.assertEqual(repo.issues[1].milestone, 'Future')
+        self.assertEqual(repo.milestones, {'Future': None, 'Next Release': None})
 
     def test_update_request_from_git(self):
         """ Test the update_request_from_git method from pagure.lib.git. """