PR#998: Cast 'version' in get_build_from_nsvc to str. - fm-orchestrator

fm-orchestrator

#998 Cast 'version' in get_build_from_nsvc to str.

Merged 5 years ago by jkaluza. Opened 5 years ago by jkaluza.

jkaluza/fm-orchestrator cast-version into master

Cast 'version' in get_build_from_nsvc to str.

Jan Kaluza • 5 years ago

78f94d1

module_build_service/models.py

file modified

+1 -1

		`@@ -297,7 +297,7 @@`
		`filter_by method.`
		`"""`
		`return session.query(ModuleBuild).filter_by(`
		`- name=name, stream=stream, version=version, context=context, **kwargs).first()`
		`+ name=name, stream=stream, version=str(version), context=context, **kwargs).first()`

		`def mmd(self):`
		`try:`

jkaluza commented 5 years ago

If we pass version as int to SQLAlchemy and PostgreSQL is used, the SQLAlchemy throws an (ProgrammingError) operator does not exist: character varying = bigint exception. The reason is that ModuleBuild.version is string in our DB schema, but Modulemd.get_version() returns int.

This PR fixes that by casting version to str everytime in get_build_from_nsvc(...).