PR#994: Remove some other noisy debug logs - fm-orchestrator

fm-orchestrator

#994 Remove some other noisy debug logs

Merged 5 years ago by ralph. Opened 5 years ago by mprahl.

quiet-debug-log into master

Remove some other noisy debug logs

mprahl • 5 years ago

713172e

module_build_service/scheduler/consumer.py

file modified

-4

		`@@ -196,9 +196,6 @@`
		`callback, key, argspec, expected))`

		`def process_message(self, session, msg):`
		`- log.debug('Received a message with an ID of "{0}" and of type "{1}"'`
		`- .format(getattr(msg, 'msg_id', None), type(msg).__name__))`
		`-`
		`# set module build to None and let's populate it later`
		`build = None`

		`@@ -218,7 +215,6 @@`
		`handler = self.on_module_change[module_build_state_from_msg(msg)]`
		`build = models.ModuleBuild.from_module_event(session, msg)`
		`else:`
		`- log.debug("Unhandled message...")`
		`return`

		`if not build:`

mprahl commented 5 years ago

These logs make it difficult to debug production since there is so much noise.

fivaldi commented 5 years ago

Can log level be changed for prod to info at least? If not, removing debug messages is an alternative (but demoted) option. Then: +1

Edited 5 years ago by fivaldi

ralph commented 5 years ago

Yeah, @fivaldi. We usually have it at info. We had to turn it to debug today to figure some stuff out, but even then this was super spammy. We can get this same info by cranking up the logging at the messaging layer.