@cpacheco can you please rebase on master so that the tests pass please? Also, can you please add unit tests for your new function?

Hi @cpacheco I don't really think that is what we wanted to do.

It should be more likely

if build_exists && status != "failed":
  return build_exists 
elif build_exists && status == "failed"
  switch module.build_state to "building"
  resubmit all failed component_builds
else:
  process_like_its_a_regular_build()
...

This change looks like will fail if the module build already exists, since I don't see you changing that behaviour.

Also brew.build on failed /successful build should work just fine. Although I'm not sure about task_id being returned back. but we could simply try to attempt to build all builds. The ones passed should get escalated back very quickly.

Thanks for the feedback. I will definitely make those changes. I didn't think about checking if the module build already exists.

I'll update unit tests once I get things working right, although I didn't see unit tests for other Poller functions under tests/tests_scheduler. I can add tests for those too if we need them.

@cpacheco closing this in favor of https://pagure.io/fm-orchestrator/pull-request/90 as previously spoken on irc