PR#794: Set the timeout on Koji sessions to 10 minutes - fm-orchestrator

fm-orchestrator

#794 Set the timeout on Koji sessions to 10 minutes

Merged 6 years ago by mprahl. Opened 6 years ago by mprahl.

koji-timeout into master

Set the timeout on Koji sessions to 10 minutes

mprahl • 6 years ago

ea34df0

module_build_service/builder/KojiModuleBuilder.py

file modified

		`@@ -258,6 +258,8 @@`
		`profile_name=config.koji_profile,`
		`user_config=config.koji_config,`
		`))`
		`+ # Timeout after 10 minutes. The default is 12 hours.`
		`+ koji_config["timeout"] = 60 * 10`

		`# In "production" scenarios, our service principal may be blessed to`
		`# allow us to authenticate as the owner of this request. But, in local`

module_build_service/builder/utils.py

file modified

		`@@ -66,6 +66,8 @@`
		`profile_name=config.koji_profile,`
		`user_config=config.koji_config,`
		`))`
		`+ # Timeout after 10 minutes. The default is 12 hours.`
		`+ koji_config["timeout"] = 60 * 10`

		`address = koji_config.server`
		`log.info("Connecting to koji %r" % address)`

mprahl commented 6 years ago

We ran into issues yesterday when there was connectivity issues with Koji, causing the backend to hang. This should help the Koji calls fail faster.

bowlofeggs commented 6 years ago

Are module builds guaranteed to be shorter than 10 minutes when working properly? Do module builds have RPM builds inside them?

mprahl commented 6 years ago

Are module builds guaranteed to be shorter than 10 minutes when working properly? Do module builds have RPM builds inside them?

RPM builds to Koji are asynchronous. We wait for Koji messages to let us know when a build state changes.

ralph commented 6 years ago

:+1: here, @mprahl.

Without doing a full inventory of all our koji calls, I bet an even lower timeout than 10 minutes could be sufficient. But, 10 minutes is a fine starting point.

Pull-Request has been merged by mprahl

6 years ago