2cb057d
39add43
@@ -48,7 +48,9 @@
return rv
except Exception:
messaging_tx_failed_counter.inc()
- raise
+ raise RuntimeError(
+ "Unable to send message to backend %r" % conf.messaging
+ )
def _fedmsg_publish(topic, msg, conf, service):
Build 67c61c0641b04cdd3777e776bc4ada60ccb4c2dc FAILED! Rebase or make new commits to rebuild.
Are you sure that all of these are errors that trigger 500 statuses (without json error info) in the frontend?
I'm pretty sure the frontend will never call the following:
rebased onto 00d3ee460af97b2415b01df55d21bba17b4c89fb
@mikem thanks, I've removed those changes.
Build 00d3ee460af97b2415b01df55d21bba17b4c89fb FAILED! Rebase or make new commits to rebuild.
UnprocessableEntity is handled in views.py as a 422 error, so I don't think we need to munge those exceptions (the changes to scm.py and default_modules.py).
The change in messaging.py looks good and should address the case that prompted me to file.
messaging.py
I don't think the other changes are in code that can be reached from the frontend. Code related ti actually performing the module builds (e.g. under module_build_service/builder) should only be running on frontend I think. But it's possible I'm missing something. Are you aware of a code path that could result in this?
So, I think that would knock it down to just the messaging.py change.
rebased onto 39add43
@mikem thanks, updated the PR to just that change.
Build 2cb057d FAILED! Rebase or make new commits to rebuild.
a couple py2 unit tests are still failing (independent of this change). I've filed #1728 to track that.
Commit d5d150d fixes this pull-request
Pull-Request has been merged by mikem
