PR#1599: Make record_module_build_arches idempotent - fm-orchestrator

fm-orchestrator

#1599 Make record_module_build_arches idempotent

Merged 4 years ago by mprahl. Opened 4 years ago by mprahl.

record-module-build-arches-idempotent into master

Make record_module_build_arches idempotent

mprahl • 4 years ago

244f29f

module_build_service/scheduler/submit.py

file modified

+2 -1

		`@@ -104,7 +104,8 @@`
		`arch_obj = db_session.query(models.ModuleArch).filter_by(name=arch).first()`
		`if not arch_obj:`
		`arch_obj = models.ModuleArch(name=arch)`
		`- build.arches.append(arch_obj)`
		`+ if arch_obj not in build.arches:`
		`+ build.arches.append(arch_obj)`

		`db_session.commit()`

tests/test_scheduler/test_submit.py

file modified

		`@@ -87,6 +87,10 @@`
		`arches = {arch.name for arch in build.arches}`
		`assert arches == set(get_build_arches.return_value)`

		`+ # Ensure the function is idempotent`
		`+ record_module_build_arches(build.mmd(), build)`
		`+ assert len(build.arches) == len(get_build_arches.return_value)`
		`+`
		`@pytest.mark.parametrize(`
		`"scmurl",`
		`[`

mprahl commented 4 years ago

This function could get called multiple times if the init handler
runs more than once. This can happen if the build failed in the
init handler due to external infrastructure being down and the
user resumes their build.

fm-orchestrator

Source Code

#1599 Make record_module_build_arches idempotent Merged 4 years ago by mprahl. Opened 4 years ago by mprahl. record-module-build-arches-idempotent into master

Metadata

Flags

Changes Summary 2

#1599 Make record_module_build_arches idempotent

Merged 4 years ago by mprahl. Opened 4 years ago by mprahl.

record-module-build-arches-idempotent into master