fm-orchestrator

Clone
Source Code
GIT

#1485 Use RuntimeError instead of ValueError when the retrieval of default modules fails
Merged 4 years ago by mprahl. Opened 4 years ago by mprahl.
surface-default-modules-error  into  master

file modified
+2 -2 
@@ -121,7 +121,7 @@ 
 

      :return: a dictionary where the keys are default module names and the values are default module
 

          streams
 

      :rtype: dict
 

-     :raise ValueError: if no default modules can be retrieved for that stream
 

+     :raise RuntimeError: if no default modules can be retrieved for that stream
 

      """
 

      scm_obj = scm.SCM(default_modules_scm_url)
 

      temp_dir = tempfile.mkdtemp()
 
@@ -167,7 +167,7 @@ 
 

      except:  # noqa: E722
 

          msg = "Failed to retrieve the default modules"
 

          log.exception(msg)
 

-         raise ValueError(msg)
 

+         raise RuntimeError(msg)
 

      finally:
 

          shutil.rmtree(temp_dir)

file modified
+1 -1 
@@ -183,7 +183,7 @@ 
 

      else:
 

          mock_get_rawhide.return_value = "something_else"
 

  

-     with pytest.raises(ValueError, match="Failed to retrieve the default modules"):
 

+     with pytest.raises(RuntimeError, match="Failed to retrieve the default modules"):
 

          default_modules._get_default_modules("f32", conf.default_modules_scm_url)
 

  

      mock_mmd_new.assert_not_called()

This will result in the error actually being in the state reason of the failed module build instead of "An unknown error occurred while validating the modulemd".

+1

Pull-Request has been merged by mprahl
4 years ago
Changes Summary 2
+2 -2
file changed
module_build_service/scheduler/default_modules.py
+1 -1
file changed
tests/test_scheduler/test_default_modules.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.