PR#1143: Revert "KojiContentGenerator: Convert MMD to UTF-8" - fm-orchestrator

fm-orchestrator

#1143 Revert "KojiContentGenerator: Convert MMD to UTF-8"

Merged 5 years ago by mprahl. Opened 5 years ago by jkaluza.

jkaluza/fm-orchestrator revert into master

Revert "KojiContentGenerator: Convert MMD to UTF-8"

Jan Kaluza • 5 years ago

73d71e1

module_build_service/builder/KojiContentGenerator.py

file modified

+1 -1

		`@@ -710,7 +710,7 @@`
		`# Fill in the list of built RPMs.`
		`mmd = self._fill_in_rpms_list(mmd, arch)`

		`- return text_type(mmd.dumps(), "utf-8")`
		`+ return text_type(mmd.dumps())`

		`def _download_source_modulemd(self, mmd, output_path):`
		`"""`

jkaluza commented 5 years ago

This reverts commit ae79b71.

This breaks MBS with python3 and fixes only single occurence of this
issue. We want to fix this in libmodulemd or find a better way how
to fix this to work on both python2 and python3.

We have libmodulemd PR open to address this issue on libmodulemd
level: https://github.com/fedora-modularity/libmodulemd/issues/184.