#1113 Fix a key error in _nudge_module_builds_in_state
Merged 7 months ago by mprahl. Opened 7 months ago by mprahl.

@@ -194,16 +194,15 @@ 

                          log.info('      * {0} components in batch {1}'

                                   .format(n, i))

  

-     def _nudge_module_builds_in_state(self, session, state, older_than_minutes):

+     def _nudge_module_builds_in_state(self, session, state_name, older_than_minutes):

          """

          Finds all the module builds in the `state` with `time_modified` older

          than `older_than_minutes` and adds fake MBSModule message to the

          work queue.

          """

-         log.info('Looking for module builds stuck in the %s state', state)

-         builds = models.ModuleBuild.by_state(session, state)

-         log.info(' {0!r} module builds in the %s state...'

-                  .format(len(builds), state))

+         log.info('Looking for module builds stuck in the %s state', state_name)

+         builds = models.ModuleBuild.by_state(session, state_name)

+         log.info(' %r module builds in the %s state...', len(builds), state_name)

          now = datetime.utcnow()

          time_modified_threshold = timedelta(minutes=older_than_minutes)

          for build in builds:

@@ -217,7 +216,7 @@ 

              session.commit()

  

              # Fake a message to kickstart the build anew in the consumer

-             state = module_build_service.models.BUILD_STATES[state]

+             state = module_build_service.models.BUILD_STATES[state_name]

              msg = module_build_service.messaging.MBSModule(

                  'nudge_module_builds_fake_message', build.id, state)

              log.info("  Scheduling faked event %r" % msg)

_nudge_module_builds_in_state would overwrite the state parameter causing the second iteration of the for loop to raise a KeyError

2 new commits added

  • Don't overwrite the state parameter in _nudge_module_builds_in_state
  • Fix a log statement in the poller
7 months ago

rebased onto fec1a8b

7 months ago

I think we actually want "anew" here :)

:+1: LGTM, just a minor wording comment.

2 new commits added

  • Don't overwrite the state parameter in _nudge_module_builds_in_state
  • Fix a log statement in the poller
7 months ago

Pull-Request has been merged by mprahl

7 months ago