Currently, when the configuration file is changed, code has to be changed so that it can be used in the app. This should be cleaned up so that any setting can be added and accessible to the app without code change.
Based on discussion here: https://pagure.io/fm-orchestrator/pull-request/73#c-5264a78a92c3fa9bc1aeaf0db3be9fc03a639331-16
I'd like to see most of the code in module_build_service/config.py removed, if possible. I don't see the value of all those @property methods. As mentioned in the #73 discussion, it seems like a waste to have to add setter/getter code whenever we want to add new config values.
module_build_service/config.py
@property
It may be that we need to retain some small portion of the module_build_service/config.py code. If so, that's okay. I would like to keep it small as possible to cut down on the number of code changes we have to make.
See PR#178
Merged here: https://pagure.io/fm-orchestrator/c/82ec1cd4d9c169d1eeb43cc00b99d18198c8de07
@fivaldi changed the status to Closed
Closed
Login to comment on this ticket.