#737 Submitting the same module twice in a very short time can result in multiple same components being recorded
Closed 6 years ago Opened 6 years ago by jkaluza.

This has happened today in MBS prod:

1) User submitted installer module - this has been handled by frontend01.
2) During the submission, the user did not wait for the response from frontend01 because of networking issues.
3) User submitted installer module again, because he thought the previous submit failed - this has been handled by frontend02.
4) Frontend01 was still busy checking the SCM refs of the submitted module, while frontend02 received request to submit the module.
5) Frontend02 found out there is already module build in progress (the one created by frontend01)
6) Frontend02 decided that this is "resubmit" of the installer build which is still being in creation phase by frontend01 and during the resubmit process, created duplicates of some components.

We could probably fix this race by resubmitting only modules which are not in the "init" state. We currently allow resubmit in "init" state because if there is some error during the init phase, we don't change the state to "failed", but we should probably do that.


We've since moved the module validation to the backend. We should test if this still occurs after that change.

We've since moved the module validation to the backend. We should test if this still occurs after that change.

On second thought, since the validation was moved to the backend, if the validation fails, the module build fails. We can now only allow resuming a module build if the build failed.

Metadata Update from @mprahl:
- Issue assigned to mprahl

6 years ago

Metadata Update from @mprahl:
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata