#734 Resubmission of a failed module build must not override the previous component_build.mmd
Closed 6 years ago Opened 6 years ago by jkaluza.

When previously failed module build is resubmitted, the utils.format_mmd method can override mmd.xmd parts of the original module build. This should not happen.

In case the module build is resubmitted, we should only mark failed component builds as component_build.state = None and don't touch anything else in module build.

I think that in submit_module_build, for the case we resubmit, we should not even call record_component_builds, but just do following:

for build in module.builds:
    if existing_build.state != koji.BUILD_STATES['COMPLETE']:
        existing_build.state = None

(This code exists in record_component_builds currently, but I think we should move it to submit_module_build and do not call record_component_builds at all)


Hey, @mprahl - I think we may have inadvertently fixed this in the last few weeks with the other changes we put in place. Does that sounds right to you?

If so, can you close this and the downstream copy (FACTORY-1501)?

Metadata Update from @mprahl:
- Issue assigned to mprahl
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata