#721 easyfix: stdout error log still mentioned in 'mbs-build local' output
Closed: Fixed 5 years ago Opened 6 years ago by karsten.

Some time ago mbs-build stopped writing empty stdout log files as requested in issue 576. But it still mentions them in the output like below:

2017-10-02 12:48:04,855 - Thread-28 - module_build_service - INFO - Executing command: ['mock', '-v', '-r', u'/home/karsten/modulebuild/builds/module-installer-master-20171002083851/config/mock-Thread-28.cfg', '--no-clean', u'--resultdir=/home/karsten/modulebuild/builds/module-installer-master-20171002083851/results/Thread-28'], stdout log: /home/karsten/modulebuild/builds/module-installer-master-20171002083851/results/blivet-gui-mock-stdout.log, stderr log: /home/karsten/modulebuild/builds/module-installer-master-20171002083851/results/blivet-gui-mock-stderr.log

please remove 'stdout log: /home/karsten/modulebuild/builds/module-installer-master-20171002083851/results/blivet-gui-mock-stdout.log' from the output


I would rather suggest information richness depending on the log level.

I mean using the current message format/data as a DEBUG level, and having some shortened message as INFO containing just the most important stuff. Possibly omitting both stdout/stderr log file paths and/or something else more?

What do you think?

(The background is that at the time when the log record appears, it's not yet known whether or not the log file will contain some useful information.)

MBS does not know what will end up in those stdout logs in the time it writes that message.

Getting rid of all that debugging output will be very welcome, and being able to get them again with --debug or DEBUG env would be awesome.
But this ticket was more of a cosmetic fix, we don't have stdout logs, so don't mention them in the output.

Metadata Update from @fivaldi:
- Issue assigned to fivaldi

6 years ago

Metadata Update from @ralph:
- Assignee reset

6 years ago

This is hard to do, because this message is generate before the command is actually executed and therefore we don't know if the stdout will be really empty.

Metadata Update from @jkaluza:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata