Issue #660: module-fe2a0d24e1b4e764 does not have glibc in PDC and in Koji Content-generator build - fm-orchestrator

fm-orchestrator

#660 module-fe2a0d24e1b4e764 does not have glibc in PDC and in Koji Content-generator build

Closed 6 years ago Opened 6 years ago by jkaluza.

It seems we added the glibc to module-fe2a0d24e1b4e764 tag, but koji_session.listTaggedRPMs has not returned that package in the time when we sent "done" state message. Both pdc-updater and MBS Koji Content Generator code is calling koji_session.listTaggedRPMs and both did not include the glibc.

However, right now, the listTaggedRPMs lists the glibc. I have no idea how to fix that or what was the problem. The true is that it happened when we tried to reuse all the componets in this module, so I presume tagging just needs some time to propagate in Koji so listTaggedRPMs actually return tagged packages.

We might need some way to check that listTaggedRPMs contains the source RPM for every component we built and retry the listTaggedRPMs for some time, although I have no idea if this actually helps... it could :)

dcallagh commented 6 years ago

Not sure if this info is helpful... but bear in mind that in Koji tagging a build is a task (with subtasks, like for sending email notifications). When you do koji tag-build in the CLI it will wait for the task to complete before it returns. So maybe MBS is not waiting for the tagBuild task to complete?

asamalik commented 6 years ago

I haven't seen the MBS code before, but by quickly looking at it, I think that @dcallagh might be right?

The koji tag-build call happens here: https://pagure.io/fm-orchestrator/blob/master/f/module_build_service/builder/KojiModuleBuilder.py#_348

And the method with the call is called here: https://pagure.io/fm-orchestrator/blob/master/f/module_build_service/scheduler/handlers/components.py#_122

I don't see any waiting there.. so unless the koji call doesn't take a while to complete, I think there is no waiting...

jkaluza commented 6 years ago

It seems the issue is that we are waiting only for builds to be tagged into -build tag, but we are not waiting for them to be tagged to final tag. Will fix that and deploy the fix in the afternoon today.