When MBS successfully finishes the build of components batch, it currently tags all the components, so they can be used as a dependency by components in next batch.
In case that some component fails to build, MBS marks the build as failed, but keeps the successfully built components from previous batches tagged. This prevents the koji garbage collector to delete the component builds.
When module build fails, MBS should untag all the tagged components from the module build tag. This will allow koji garbage collector to eventually remove the untagged builds.
@ausil, could you please help us (me) here answering these questions and also review the proposed solution above and eventually suggest some changes?
Should MBS also remove the tag completely, or will koji-gc remove the tag itself when there are no components tagged to it for some time?
In case we untag the components and koji-gc removes them, will the build log be still accessible, so developers can see the reason why the build failed?
What is the default timeout after which the builds are removed by koji-gc?
@jkaluza @ralph mentioned the "resume failed build" use-case, which should reuse components that built successfully. Wouldn't this post-failure cleanup break the resume use-case?
Yes - we'll need to build in some kind of fuse, so that the builds don't get untagged and cleaned up until some time delta after the build fails. ... so we can still support the 'resume' scenario.
Metadata Update from @mprahl: - Issue assigned to mprahl
PR #795 addresses this
Metadata Update from @mprahl: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.