#48 add_dependency / connect_buildroot - current implementation might lead to unexpected dependencies
Closed 6 years ago Opened 7 years ago by lkocman.

What I'm trying to solve here is unexpected extra tag inheritance (from e.g. previously failed module build).

There is a problem that we currently don't have a way to say whether all dependencies (koji tag-inheritance) are correct. E.g first build of given module might have contained different depedencies than the re-submitted one.

It would be nice to e.g. do add_dependency only before buildroot_connect (enforce through check of self.__prep).

And buildroot_connect would do comparison of self._dependencies vs build tag inheritance.

Thoughts?


Seems like we need a way to remove_dependency too.

Looking at this again during grooming. It is not clear to me whether or not this is still a problem.

When this comes up in a sprint, someone should investigate first to make sure that the problem is or is not still really a problem.

I think this is not a problem anymore.

Metadata Update from @ralph:
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata