#434 Return a nice error if user submits invalid hash or url or branch
Closed: Fixed 6 years ago Opened 7 years ago by ralph.

Currently, if the user submits a hash to MBS that they forgot to push to dist-git, we see errors on the httpd logs like:

[Wed Mar 15 13:53:07.414267 2017] [:error] [pid 6723] DEBUG:module_build_service:Verifying modulemd
[Wed Mar 15 13:53:07.822060 2017] [:error] [pid 6723] WARNING:module_build_service:error: pathspec 'abffed4' did not match any file(s) known to git.
[Wed Mar 15 13:53:07.822074 2017] [:error] [pid 6723] 
[Wed Mar 15 13:53:07.822186 2017] [:error] [pid 6723] WARNING:module_build_service:Exception RuntimeError('Failed on [\\'git\\', \\'checkout\\', \\'-q\\', \\'abffed4\\'], retcode 1, out \\'\\', err "error: pathspec \\'abffed4\\' did not match any file(s) known to git.\\\\n"',) raised from <function _run at 0x7f6bc983dde8>.  Retry in 30s

... and then we return a 500 error to the user.

We should return something nicer, with a nice error code and nice error message.


Metadata Update from @fivaldi:
- Issue assigned to fivaldi

7 years ago

PR#462 should solve this problem.

Metadata Update from @jkaluza:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata