#186 [RFE] When building modules, pass `--nocheck` to mock
Closed 7 years ago Opened 7 years ago by sgallagh.

The --nocheck argument to mock is passed directly on to rpmbuild. It indicates that RPM can skip running whatever tests are specified within the %check section of the RPM spec file for this build.


So, this will require a patch to koji, right?

The question there will be:

  • Do we set the --nocheck option on a tag-wide level? Or on a per-build basis?

I think setting it on a tag-wide level will be the most amenable to the koji upstream devs.

It suits us too, since our service controls the creation of the tags. We can create tags with the appropriate option and voila!

Tag-wide makes sense.

This will speed up our initial builds where we can still, somewhat, rely on test results from the classic release package builds. Perhaps we could have a toggle in the xmd section to enable this feature?

Just a note, @mikeb is reluctant to say "let's do this".

I would close this as wontfix. Building our selfhosting set showed us packages that pass in the standard release fail their test suites when built in our environment. This uncovers bugs and is therefore a good thing.

@ralph changed the status to Closed

7 years ago

Login to comment on this ticket.

Metadata