fm-orchestrator

#1738 module_build_service fails due to missing return statement.
Closed: Fixed by mikem. Opened by jaydoubleu.

Closed: Fixed
Reopen Issue 
BUILDING MODULE
===============
Traceback (most recent call last):
  File "/usr/bin/mbs-manager", line 33, in <module>
    sys.exit(load_entry_point('module-build-service==3.6.1', 'console_scripts', 'mbs-manager')())
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/flask/cli.py", line 600, in main
    return super().main(*args, **kwargs)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 1053, in main
    rv = self.invoke(ctx)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/flask/cli.py", line 444, in decorator
    return __ctx.invoke(f, *args, **kwargs)
  File "/var/home/jaydoubleu/.local/lib/python3.10/site-packages/click/core.py", line 754, in invoke
    return __callback(*args, **kwargs)
  File "/usr/lib/python3.10/site-packages/module_build_service/manage.py", line 133, in build_module_locally
    db.create_all()
  File "/usr/lib/python3.10/site-packages/flask_sqlalchemy/__init__.py", line 1094, in create_all
    self._execute_for_all_tables(app, bind, 'create_all')
  File "/usr/lib/python3.10/site-packages/flask_sqlalchemy/__init__.py", line 1086, in _execute_for_all_tables
    op(bind=self.get_engine(app, bind), **extra)
  File "/usr/lib/python3.10/site-packages/flask_sqlalchemy/__init__.py", line 1017, in get_engine
    return connector.get_engine()
  File "/usr/lib/python3.10/site-packages/flask_sqlalchemy/__init__.py", line 593, in get_engine
    sa_url, options = self.get_options(sa_url, echo)
  File "/usr/lib/python3.10/site-packages/flask_sqlalchemy/__init__.py", line 608, in get_options
    sa_url, options = self._sa.apply_driver_hacks(self._app, sa_url, options)
TypeError: cannot unpack non-iterable NoneType object

Adding return on front of https://pagure.io/fm-orchestrator/blob/master/f/module_build_service/init.py#_60 solves the problem. ( Thanks to @otaylor

Thanks, that fixes it for me on F35 and lets me drop my F34 toolbox. Care to file a PR?

Thank you for the fix, but this has been addressed another way (see #1670). Can you try with current HEAD?

@jaydoubleu @yselkowitz any chance you can try current HEAD to see if this also addresses the issue for you?

Closing. Let us know if current HEAD does not solve your issue.

Metadata Update from @mikem:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

This issue has been migrated to Fedora Forge:
https://forge.fedoraproject.org/koji/mbs/issues/1738

Please continue any further discussion there.
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.