The pytest options added in commit dd1f918 break contrib/run-unittests.sh.
contrib/run-unittests.sh
The error is:
ERROR: usage: py.test [options] [file_or_dir] [file_or_dir] [...] py.test: error: unrecognized arguments: --cov --cov-report html --cov-report term tests/test_content_generator.py inifile: /root/mbs/src/tox.ini rootdir: /root/mbs/src
Perhaps the test image needs to be updated?
The command does succeed if I pass --py3 (which uses a different test image). Not sure if this is really py2 vs py3 or centos vs fedora.
--py3
@mikem, are you using the latest container image?
are you using the latest container image?
I'm using whatever the script does. An example invocation is:
./contrib/run-unittests.sh --sudo tests/test_content_generator.py
This ends up running:
sudo /usr/bin/docker run --rm -v /home/mike/Devel/fm-orchestrator:/src:z --name mbs-test-085618 -i -t quay.io/factory2/mbs-test-centos /root/mbs/src/tests/test_content_generator.py
@mikem, try the following command:
sudo docker pull quay.io/factory2/mbs-test-centos
I think it's because your local container image is out of date.
Would it make sense to have run-unittests.sh run the docker pull command?
run-unittests.sh
Sure. Feel free to file a PR.
Commit 0d8af77 relates to this ticket
I think #1465 is really the only 'fix' that is needed here. Closing
Metadata Update from @mikem: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.