#3429 Change: Package-specific RPM Macros For Build Flags
Closed: Accepted 7 months ago by zbyszek. Opened 8 months ago by amoloney.

Create "extra flag" macros to make it easier for packages to add to the default list of compiler flags.

This is a follow up to the: https://fedoraproject.org/wiki/Changes/RPMMacrosForBuildFlags

Owners, do not implement this work until the FESCo vote has explicitly ended.
The Fedora Program Manager will create a tracking bug in Bugzilla for this Change, which is your indication to proceed. See the FESCo ticket policy and the Changes policy for more information.

REMINDER: This ticket is for FESCo members to vote on the proposal. Further discussion should happen in the Discourse discussion linked above. Additional discussion may happen on the Fedora Devel mailing list.


The lack of the dash in the compound adjective makes it title hard to understand. It should be "Package-specific …".

https://www.merriam-webster.com/grammar/hyphen-rules-open-closed-compound-words explains this well:

when a compound that is usually left open is used to modify another noun, that compound will usually take a hyphen. [...]
the hyphen is sometimes dropped for very common terms that aren’t likely to be misunderstood [emphasis mine]

In this case, "package" could be both a noun, an adjective, or a verb, and the most natural interpretation in this sentence is as a verb. Thus, the hyphen is necessary to prevent misunderstanding.

Please change the title. (Also rename the page. Mediawiki handles renames very well.)

As discussed in the fedora-devel thread, the exact naming and details could be modified based on feedback. I think the proposed naming is OK, but it'd be fine if the implementation was adjusted later; I understand the proposal to include that possibility.

+1

After a week:
APPROVED (+4, 0, 0)

Metadata Update from @zbyszek:
- Issue tagged with: pending announcement

7 months ago

The lack of the dash in the compound adjective makes it title hard to understand. It should be "Package-specific …".

https://www.merriam-webster.com/grammar/hyphen-rules-open-closed-compound-words explains this well:

when a compound that is usually left open is used to modify another noun, that compound will usually take a hyphen. [...]
the hyphen is sometimes dropped for very common terms that aren’t likely to be misunderstood [emphasis mine]

In this case, "package" could be both a noun, an adjective, or a verb, and the most natural interpretation in this sentence is as a verb. Thus, the hyphen is necessary to prevent misunderstanding.

Please change the title. (Also rename the page. Mediawiki handles renames very well.)

As discussed in the fedora-devel thread, the exact naming and details could be modified based on feedback. I think the proposed naming is OK, but it'd be fine if the implementation was adjusted later; I understand the proposal to include that possibility.

+1

Thanks for explanation, I fixed the Change title and moved the wiki page.

Metadata Update from @zbyszek:
- Issue untagged with: pending announcement
- Issue close_status updated to: Accepted
- Issue status updated to: Closed (was: Open)

7 months ago

Log in to comment on this ticket.

Metadata