It sometimes happens that Python packages succeed to build as RPM with incorrect version metadata. They generate a wrong provide in format python3dist(...) = 0 and python3.Xdist(...) = 0. While version 0 (or equal versions like 0.0 or 0.0.0) is probably technically valid, in most cases this indicates a packaging error. We propose to prevent this error from happening by explicitly failing the RPM build instead of generating such provides.
python3dist(...) = 0 and python3.Xdist(...) = 0
Owners, do not implement this work until the FESCo vote has explicitly ended. The Fedora Program Manager will create a tracking bug in Bugzilla for this Change, which is your indication to proceed. See the FESCo ticket policy and the Changes policy for more information.
+1
I think it's a seriously bad idea to be this prescriptive to straight-up fail package builds with no workarounds of any kind on something that is considered valid in Python.
-1
@ngompa: I thinked you missed that latest discussion. The change page now says:
Based on the discussion on fedora-devel mailing list, there will be a mechanism to opt out from this change. A macro with a provisional name (TBD) %__python_dist_allow_version_zero will be created. [...]
I think it's a seriously bad idea to be this prescriptive to straight-up fail package builds with no workarounds of any kind on something that is considered valid in Python. -1
Based on the devel thread I reworked the page yesterday (will post update to the thread). Please review the current proposal. Thank you.
Diff link: https://fedoraproject.org/w/index.php?title=Changes%2FPrevent-Providing-python3dist%28pkg%29%3D0&type=revision&diff=661559&oldid=661127
Okay, revised. +1
I agree that it’s wise to have a documented opt-out since the zero version is technically valid, although I will be very surprised if the opt-out is ever used even once in practice.
This proposal would have caught several subtle packaging mistakes in my own packages, and I strongly welcome it overall.
With the opt-out, looks good to me. +1
After a week, the vote is APPROVED (+7,0,-0)
Metadata Update from @bcotton: - Issue tagged with: pending announcement
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/2ZKJ7FWMOIXERV5AFH6I5G5R5WRLQTU3/
Metadata Update from @churchyard: - Issue close_status updated to: Accepted - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.