Create a corresponding macro for each compiler flag in the redhat-rpm-config macro file and create "extra flag" macros to make it easier for packages to add and remove compiler flags.
Owners, do not implement this work until the FESCo vote has explicitly ended. The Fedora Program Manager will create a tracking bug in Bugzilla for this Change, which is your indication to proceed. See the FESCo ticket policy and the Changes policy for more information.
+1
After a week, the vote is
APPROVED (+4,0,-0)
Metadata Update from @bcotton: - Issue tagged with: pending announcement
Announced: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/AEF4US5TEZK66YLG7UGGIGWW2HYP732E/
Metadata Update from @zbyszek: - Issue untagged with: pending announcement - Issue close_status updated to: Accepted - Issue status updated to: Closed (was: Open)
There are some ongoing technical discussions about how to implement adding and removing existing flags, so we've decided to postpone the change to Fedora 38. However, if possible, I would like to implement a subset of this change for Fedora 37, which is the addition of the following macros:
%_pkg_extra_cflags %_pkg_extra_cxxflags %_pkg_extra_fflags %_pkg_extra_ldflags
Unlike the rest of the change, adding these macros is unobtrusive and so the contingency deadline could be the Beta Freeze instead of the Mass Rebuild.
Would FESCO be OK with this modified proposal?
So you'd basically only the "first half" of "Detailed Description"? Looks good to me.
+1 for the same proposal with only the %_pkg_extra_* macros.
%_pkg_extra_*
This would remove the need to update the guidelines “to require that all new flags added to redhat-rpm-config have their own RPM macro,” but I would still recommend that the new macros should be documented in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags.
To make it clear, I went through and updated the whole proposal, so it only covers the new pkg_extra* macros. I would like to try to implement this for F38, can FESCO re-vote on this new proposal?
I think it's better from process POV to open a new ticket to vote again. @bcotton should we do that?
→ https://pagure.io/fesco/issue/2905
Login to comment on this ticket.