#2610 F35 Change: Broken RPATH will fail rpmbuild
Closed: Accepted 2 months ago by churchyard. Opened 2 months ago by bcotton.

Enable broken RPATH detection buildroot policy script by default. This will make the RPM build fail once a broken RPATH was detected within a binary or a shared library file. An opt-out mechanism will be provided as well.


Noting here that there is also an alternative proposal on the devel list discussion to utilize --enable-new-dtags for all the packages, which would essentially eliminate RPATH entirely and move everything to RUNPATH and then to apply the RPATH rules of this change to RUNPATH.

This could be a better solution although I would consider it a step further down the line (e.g. for F36 maybe).

Also cc'ing @tibbs here.

%define __brp_check_rpaths %{nil} — shouldn't that be %global?

+1

The packaging guidelines are inconsistent wrt this. At one point, they say to prefer %global over %define, but the BRP guideline actually says %define.

There is a ticket: https://pagure.io/packaging-committee/issue/898

%define __brp_check_rpaths %{nil} — shouldn't that be %global?

+1

Amended, thanks.

It has been a week and this change proposal is APPROVED (+3,0,-0).

Metadata Update from @churchyard:
- Issue tagged with: pending announcement

2 months ago

Metadata Update from @churchyard:
- Issue close_status updated to: Accepted
- Issue status updated to: Closed (was: Open)

2 months ago

Login to comment on this ticket.

Metadata