This has been discussed on devel@ and test@ with what I'd characterize as "generally positive feedback". It was suggested it should go through some kind of review, though, so I'm submitting it to a FESCo vote (I really don't want to sit through the entire Change process, plus it doesn't seem a particularly good fit for it).
The proposal is to gate pushes for critical path updates on the openQA test results. More details are in the email, I won't re-type it. This would be implemented by merging this bodhi PR, though there's a Greenwave bug that should be fixed first. Note that as it stands, that Bodhi PR gates pushes to testing and stable; it could be changed to only gate push to stable, but to me gating push to testing makes sense, it can help protect us against broken updates going to human testers.
@churchyard @kkofler
+1
+1 to try it out to collect more feedback, with a contingency to revert and revisit if there is too much confusion (which I hope goes without saying)
I agree gating push to testing makes sense. Thanks for suggesting this.
+1, what @churchyard said
+1, Preventing obviously broken packages from getting pushed even to testing sounds great.
+1, emphatically.
Make sure to over-communicate this as many people will not notice this and complain :)
And technically this is approved since it has been 7 days.
APPROVED (+8, 0, -0)
Metadata Update from @ignatenkobrain: - Issue tagged with: pending announcement
Thanks folks. Greenwave is updated, and I'm now asking to merge the Bodhi PR. I'm writing to the mailing lists to communicate that this is going forward. For the record, in case something unexpected happens and I'm not around, it's easy to "turn this off": edit the greenwave config in infra ansible, delete the entire "bodhiupdate_bodhipush_openqa" policy, push that change, and re-run the greenwave playbook (obviously someone from infra with the necessary permissions is needed for that).
"bodhiupdate_bodhipush_openqa"
Announced: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/TFLL7YSBN5YRDBGVCYRJKXP63YK332UK/
Metadata Update from @ngompa: - Issue close_status updated to: Accepted - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.