+1

I guess the scope is not complete because one would also need to change presets.

+1

@benzea @gicmo make sure to fix thermald so that by default it does not show useless, non-actionable warnings.

Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]sensor id 10 : No temp sysfs for reading raw temp
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]sensor id 10 : No temp sysfs for reading raw temp
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]sensor id 10 : No temp sysfs for reading raw temp
Jul 08 20:03:18 igors-t480s thermald[143083]: I/O warning : failed to load external entity "/etc/thermald/thermal-conf.xml"
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]error: could not parse file /etc/thermald/thermal-conf.xml
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]sysfs open failed
Jul 08 20:03:18 igors-t480s thermald[143083]: I/O warning : failed to load external entity "/etc/thermald/thermal-conf.xml"
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]error: could not parse file /etc/thermald/thermal-conf.xml
Jul 08 20:03:18 igors-t480s thermald[143083]: I/O warning : failed to load external entity "/etc/thermald/thermal-conf.xml"
Jul 08 20:03:18 igors-t480s thermald[143083]: [1594231398][WARN]error: could not parse file /etc/thermald/thermal-conf.xml

@ignatenkobrain

Yes, you are right, the preset also needs to be changed. And I have also filed the corresponding PR to do this.

I opened https://github.com/intel/thermal_daemon/issues/237 for the warnings. Depending on how important this is to you, I could look into it myself. However, I am really not sure how easy it is to address the issue.

This was also discussed in the Workstation WG meeting:

https://pagure.io/fedora-workstation/issue/71#comment-663862

Discussed at today's meeting. We've reversed our previous decision based on the understanding that (a) dptfxtract is not actually strictly required, and (b) Ubuntu has been shipping thermald without dptfxtract for six years. thermald is approved.

1. Please add ConditionVirtualization=no to thermald.service. This will already cut down the log spew quite a bit.
2. The logs that termald outputs are simply bad.
   "[1594231398][WARN]" — that's just noise. Thermald is logging to the journal, not to a text file, and any prefixes like that should be dropped.
   It also "warns" about the things which are completely normal and OK.
   And it repeats the same log lines over and over.

Log spew is not just a cosmetic issue, it makes usability of the machine worse. Users should be able to look at the logs from a boot and not have any lines at warning or higher level, unless there are actual problems to fix. Various services dump garbage to the logs and this makes it hard to debug anything when there are real problems, because the user is buried by "warnings" and "fatal errorz" that they need to wade through first. And users have no way to know how serious those issues really are.

I'll be happy to vote +1, but only if there's a plan to fix the warnings.

1. https://github.com/intel/thermal_daemon/pull/238 (merged upstream)
2. https://github.com/intel/thermal_daemon/pull/240 (merged upstream, there were also further fixes by the upstream author)

That removes the noise when logging to syslog, lowers the severity of a number of them and should prevent XML parsing errors for missing files.

After a week, this is (+2,0,-0), keeping open.

(I personally wasn't bale to dedicate time to this proposal, sorry.)

+1 here with the changes above.

+1

My opinion on this Change is rather meh, so I will abstain from voting.

Since one additional week is over, and +2 were given - this is APPROVED (+4, 1, -0).

Announced: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/NHIKO64AWRW72LEOD3LMJ5E6FJT62CED/