This is a proposal to enable link time optimization (LTO) of packages built with rpmbuild by default. It's an over-simplification, but think of LTO as deferring analysis, optimization and code generation until creation of an executable or dynamic shared object.
This is implemented by adding the option "-flto" the injected flags in redhat-rpm-config. There will be a simple way for packages to opt-out of LTO.
I am definitely +1 on the idea of the change. However, I'd like to see the implementation before actually saying YES. Based on change description, you always have tested it and ready, can you submit your PRs and collect links here please?
+1
Also want to see the implementation.
I'm inclined to vote +1.
@law can you open PRs against against the packages that need to be modified for this? I'd like to see the implementation for:
-flto
FOOFLAGS
%configure
I suspect that we'll also need to add text about the LTO opt-out to the packaging guidelines.
Or at least to https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/master/f/buildflags.md
Definitely +1.
APPROVED +7,0,-0
Metadata Update from @churchyard: - Issue tagged with: pending announcement
On Sat, 2020-01-04 at 11:07 +0000, Fabio Valentini wrote:
decathorpe added a new comment to an issue you are following: `` I'm inclined to vote +1. @law can you open PRs against against the packages that need to be modified for this? I'd like to see the implementation for: the -flto flag injection into FOOFLAGS plus opt-out mechanism, the %configure hacks, and the BRP scripts necessary for stripping LTO bytecode. Will do. I may split this up into 3 distinct bugs as they're logically distinct changes. I suspect that we'll also need to add text about the LTO opt-out to the packaging guidelines. I agree.
decathorpe added a new comment to an issue you are following: `` I'm inclined to vote +1.
I suspect that we'll also need to add text about the LTO opt-out to the packaging guidelines. I agree.
jeff
``
Just an FYI. I realize it's already approved, but since folks asked, I have created 3 BZs and pull-requests for redhat-rpm-config. One for each of the issues noted above:
https://bugzilla.redhat.com/show_bug.cgi?id=1789099 https://bugzilla.redhat.com/show_bug.cgi?id=1789137 https://bugzilla.redhat.com/show_bug.cgi?id=1789149
Announced.
Metadata Update from @psabata: - Issue untagged with: pending announcement - Issue close_status updated to: Accepted - Issue status updated to: Closed (was: Open)
This proposal was deferred to F33 by the owner.
Metadata Update from @bcotton: - Issue tagged with: F33
Metadata Update from @bcotton: - Issue untagged with: F32, F33 - Issue set to the milestone: Fedora 33
Login to comment on this ticket.