#1979 F30 Change: Make ambiguous python shebangs error
Closed: Accepted 5 years ago Opened 5 years ago by bcotton.

The /usr/lib/rpm/redhat/brp-mangle-shebangs buildroot policy script will be changed to make the build fail when it sees an ambiguous python shebang, such as #!/usr/bin/python or #!/usr/bin/env python. (The script has been warning in these cases for 2 Fedora releases already, saying This will become an ERROR.)


How many packages are affected by this? Does/did taskotron notify maintainers about this or did they have to stumble upon this in some log file? Would be great to ensure that the maintainers get a proper heads-up. Other than that, I am +1.

The taskotron check failed, however packagers may not have been directly notified about it by e-mail etc.

They could have seen the results when doing bodhi updates.

I'll work with Taskotron people to get the list of packages where this failed for the latest rawhide build and I will send an e-mail to the maintainers. That said, I think the only thing that would make the majority of maintainers to correct this is to render their build failed :(

I'm +1 to this change, but would love to see more proactive communication with the affected package owners, whether it is from Taskotron or some other mechanism.

I know that packagers don't always keep up on the latest changes, and it's pretty frustrating as a packager to experience a package that won't build that used to build just fine, thanks to external changes.

It's been a week and I count +6 for this change.

Metadata Update from @bowlofeggs:
- Issue tagged with: pending announcement

5 years ago

Metadata Update from @bowlofeggs:
- Issue untagged with: pending announcement
- Issue close_status updated to: Accepted
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata