#1909 Allow to have %{?suse_version} condition in spec file
Closed 5 years ago Opened 5 years ago by mhabrnal.

Hi,

lately, we unified upstream spec files with the downstream ones to make releases of all ABRT's packages much easier for maintainers.

Due to this rule in [1], we would like to ask for an exception to be able to have SUSE related conditions in the downstream spec file. Is it possible to have %{?suse_version} condition in the downstream spec files or should I remove them?

Regards
Matej

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility


Metadata Update from @bowlofeggs:
- Issue tagged with: meeting

5 years ago

This is on the agenda for Friday's FESCo meeting at 15:00UTC in #fedora-meeting on irc.freenode.net, but note that we may not get to it as there is a large agenda and this is the 9th item in line.

I think that we should let the FPC decide this, or at least ask for their opinion.

How does the spec file in question look like with the macros?

AGREED: Defer to FPC, but indicate that FESCo suggests that the "readibility" guidelines can be relaxed. (+7, 0, -0)

To clarify that a bit, FESCo has established the Fedora Packaging Committee (FPC) to make packaging guidelines, and we feel this decision is best left to them. FESCo believes that the readability guidelines can be relaxed, but ultimately leaves that decision to the FPC since they were established for that purpose.

You can file a ticket with the FPC here to ask them for a decision: https://pagure.io/packaging-committee/

Metadata Update from @bowlofeggs:
- Issue untagged with: meeting
- Issue status updated to: Closed (was: Open)

5 years ago

For what it's worth, while I very much prefer readable packaging, as a package maintainer for software across multiple RPM based distributions (Fedora, RHEL/CentOS, Mageia, openSUSE, et al), it'd be way nicer if I could leverage the same spec everywhere.

However, I think if we allow it, we should absolutely document how these conditionals work, similar to what openSUSE has in their guidelines (though a bit more up to date... Mandriva is dead, after all...).

Login to comment on this ticket.

Metadata