From 416afb925e64f549ccf4520aefba725555a5188d Mon Sep 17 00:00:00 2001
From: Otto Urpelainen <oturpe@iki.fi>
Date: Mar 12 2022 12:06:25 +0000
Subject: Improve Packager Sponsor policy


Some further improvements to Packager Sponsor Policy,
stemming from reviewing Package Maintainer Docs page
How to Get Sponsored into the Packager Group.

---

diff --git a/fesco/modules/ROOT/pages/Packager_sponsor_policy.adoc b/fesco/modules/ROOT/pages/Packager_sponsor_policy.adoc
index a0e8b37..973d8c0 100644
--- a/fesco/modules/ROOT/pages/Packager_sponsor_policy.adoc
+++ b/fesco/modules/ROOT/pages/Packager_sponsor_policy.adoc
@@ -37,10 +37,12 @@ There are several ways to get sponsored into the `packager` group.
 [#submitting]
 === Submitting a package
 
-Sponsorship can be requested when a review request is submitted for a new package,
+Sponsorship can be requested when a xref:Package_review_policy.adoc[review request] is submitted for a new package,
 or for a retired package that requires a new review.
 Such request is submitted by making the review request Bugzilla ticket block the
 https://bugzilla.redhat.com/show_bug.cgi?id=FE-NEEDSPONSOR[FE-NEEDSPONSOR] tracking bug.
+Although `FE-NEEDSPONSOR` is set on the package's review request,
+it is the person that needs to be sponsored, not the package.
 
 [#comaintainer]
 === Becoming a co-maintainer
@@ -77,13 +79,6 @@ and link to them in their sponsorship request.
 Sponsors can then give feedback on these pull requests
 and evaluate the applicant's knowledge at the same time.
 
-[#other_paths]
-=== Other paths
-
-Sponsors can also decide to accept an applicant based on other types of contributions.
-For example, the applicant may be the upstream maintainer for the project,
-or may have done other contributions to packaging that do not fit into one of categories above.
-
 [#requirements]
 == Sponsorship requirements
 
@@ -98,6 +93,8 @@ The sponsor only needs to trust that the primary maintainer will give the requir
 The following sections describe some actions that may be taken by the applicant
 to show their packaging skills.
 
+The applicant should include all relevant information in their application.
+
 [#open_prs]
 === Opening pull requests
 
@@ -115,8 +112,19 @@ and the xref:packaging-guidelines::index.adoc[Fedora Packaging Guidelines].
 === Commenting on review requests
 
 Applicants can demonstrate their level of understanding by commenting on package review requests.
-Such comments should follow the usual package review format,
+This also helps out the other reviewers, which will be much appreciated.
+
+Such comments should follow the usual xref:packaging-guidelines::ReviewGuidelines.adoc[Review Guidelines],
 but clearly state that the commenter is not yet a packager and the review is thus unofficial.
+While it is not strictly necessary to work through the entire checklist,
+more comprehesive reviews are more valuable.
+
+[#other_contributions]
+=== Other contributions
+
+Sponsors can also decide to accept an applicant based on other types of contributions.
+For example, the applicant may be the upstream maintainer for the project,
+or may have done other contributions to packaging that do not fit into one of categories above.
 
 [#responsibilities]
 == Package sponsor responsibilities
@@ -214,3 +222,9 @@ If not, the request is closed.
 The applicant may reapply anytime they feel they have more support.
 After the new permissions to propagate through the system,
 the accepted applicant is able to sponsor new packagers.
+
+[[guides]]
+== Guides
+ 
+ * xref:package-maintainers::How_to_Get_Sponsored_into_the_Packager_Group.adoc[How to Get Sponsored into the Packager Group]
+ 
\ No newline at end of file