#31 Skip epel check
Merged 3 years ago by mohanboddu. Opened 3 years ago by mohanboddu.
mohanboddu/fedscm-admin skip-epel-check  into  master

file modified
+2 -1
@@ -94,7 +94,8 @@ 

  INVALID_EPEL_ERROR = (

      'This package is already an EL package and is built on all supported '

      'arches, therefore, it cannot be in EPEL. If this is a mistake or you '

-     'have an exception, please contact the Release Engineering team.')

+     'have an exception, please contact the Release Engineering team at'

+     'https://pagure.io/releng/issues')

  today = datetime.utcnow().date()

  # Remove any branches that have gone EOL since these were hardcoded. This data

  # should really be in PDC, but there is not suitable API yet.

file modified
+6 -4
@@ -347,8 +347,9 @@ 

      # here, it'd have to be accompanied by a Bugzilla bug for the "Fedora EPEL"

      # product. So this will only trigger if the reviewer made a mistake.

      if is_epel(branch_name) and not valid_epel_package(repo, branch_name):

-         prompt_to_close_bad_ticket(issue_json, INVALID_EPEL_ERROR)

-         return

+         if not force:

+             prompt_to_close_bad_ticket(issue_json, INVALID_EPEL_ERROR)

+             return

  

      issue_id = issue_json['id']

      issue_owner = issue_json['user']['name']
@@ -525,8 +526,9 @@ 

  

      branch_name = issue_body_json['branch'].strip()

      if is_epel(branch_name) and not valid_epel_package(repo, branch_name):

-         prompt_to_close_bad_ticket(issue_json, INVALID_EPEL_ERROR)

-         return

+         if not force:

+             prompt_to_close_bad_ticket(issue_json, INVALID_EPEL_ERROR)

+             return

      # Pagure uses plural names for namespaces, but PDC does not use the

      # plural version for branch types

      branch_type = fedscm_admin.pdc.component_type_to_singular(namespace)

Sometimes we need to skip epel check.
For ex: https://pagure.io/releng/issue/9360

Signed-off-by: Mohan Boddu mboddu@bhujji.com

rebased onto 5a92f424cb31f8dd567d39112b3fba91ad119146

3 years ago

Should we add or modify some tests for that ?

Otherwise looks good

rebased onto 97a6ba9

3 years ago

I have to add couple of test cases, I will add them later.

Pull-Request has been merged by mohanboddu

3 years ago