#419 Do not show warning when 'package.cfg' is missing
Merged 3 years ago by onosek. Opened 3 years ago by onosek.
onosek/fedpkg package_cfg_warning  into  master

file modified
-4
@@ -1202,10 +1202,6 @@ 

          """Read configured releases from build config from repo"""

          config_file = os.path.join(self.cmd.path, LOCAL_PACKAGE_CONFIG)

          if not os.path.exists(config_file):

-             self.log.warning('No local config file exists.')

-             self.log.warning(

-                 'Create %s to specify build targets to build.',

-                 LOCAL_PACKAGE_CONFIG)

              return None

          config = configparser.ConfigParser()

          if not config.read([config_file]):

EPEL sig decided that playground branch won't be required for epel8.
In 'package.cfg' there was a list of target branches. Now it is not
necessary to have this configuration file in the repository. Warning
about missing this configuration is removed. Config file (if present)
still works as previously.

JIRA: RHELCMP-2667
Fixes: #417

Signed-off-by: Ondřej Nosek onosek@redhat.com

This PR contains only warning removal. I am not sure whether to remove the whole 'config.cfg' support from rpkg as described in original issue #417.

Looks good to me.

I'm also not confident removing the functionality is a good move now, it would be a backwards incompatible change.

Pull-Request has been merged by onosek

3 years ago
Metadata