PR#378: Removes check of bodhi-client version - fedpkg

fedpkg

#378 Removes check of bodhi-client version

Merged 4 years ago by onosek. Opened 4 years ago by onosek.

onosek/fedpkg remove_bodhi_check into master

Removes check of bodhi-client version

Ondrej Nosek • 4 years ago

f97ef59

fedpkg/cli.py

file modified

+1 -5

		`@@ -87,13 +87,9 @@`

		`def check_bodhi_version():`
		`try:`
		`- dist = pkg_resources.get_distribution('bodhi_client')`
		`+ pkg_resources.get_distribution('bodhi_client')`
		`except pkg_resources.DistributionNotFound:`
		`raise rpkgError('bodhi-client < 2.0 is not supported.')`
		`- major = int(dist.version.split('.', 1)[0])`
		`- if major >= 5:`
		`- raise rpkgError(`
		`- 'This system has bodhi v{0}, which is unsupported.'.format(major))`


		`class fedpkgClient(cliClient):`

onosek commented 4 years ago

Removes check of bodhi-client version

Modification of this part of the code is not needed when a new major
version of Bodhi is released (if there are no incompatibilities with
previous Bodhi version).
This approach was chosen instead of bumping the version every time there
is a Bodhi major release.

JIRA: COMPOSE-3860
Fixes: rhbz#1796972

Signed-off-by: Ondrej Nosek onosek@redhat.com

onosek commented 4 years ago

This is already applied patch. Just add it to the master branch.

rebased onto 4196ac7a9670752e7e5ac8b6f2eab3e3a1a9735a

4 years ago