#228 Add new command for creating override in Bodhi
Merged by cqi. Opened by cqi.
cqi/fedpkg subcommand-for-overrides  into  master

Download 228.patch

To create a buildroot override, run inside a package repo:

fedpkg override create --duration 5

It also accepts a specified build:

fedpkg override create --duration 5 rpkg-1.54-2.fc27

Fixes #92

Signed-off-by: Chenxiong Qi cqi@redhat.com

bodhi-client cannot be installed from pypi.org due to https://github.com/fedora-infra/bodhi/issues/2401

Looks like a typo: expieration -> expiration.

There's some inconsistency here: nvr:%s but notes=%s. Maybe use = everywhere?

I think Consider using command is grammatically better.

Actually which command is this? I don't see fedpkg override extend, will you add it later? Or are users expected to use bodhi cli?

This looks pretty cool!

I'm not a big fan of the default note No explanation given.... Is the value required by Bodhi? If yes, fedpkg should force users to give some notes. If not, maybe it could be left blank?

Yes. It is fedpkg override extend that will be added after this.

rebased onto 532c1171316bd69c3e0140ba43269db61cc9427f

I'm not a big fan of the default note No explanation given.... Is the value required by Bodhi? If yes, fedpkg should force users to give some notes. If not, maybe it could be left blank?

Notes must contain some text. I didn't figure out a better choice, so just keep it same as the default text bodhi has.

@lsedlar all the issues are fixed. Also add more command description.

Looks good to me. I didn't try to run it though.

pretty please pagure-ci rebuild

Pretty please pagure-ci rebuild

@lsedlar for your convenience, there is f28 build containing this patch
https://koji.fedoraproject.org/koji/taskinfo?taskID=27450619

Pull-Request has been merged by cqi

Metadata