#2 Lookaside improvements
Merged by ausil. Opened by bochecha.
Unknown source master

Download 2.patch
no initial comment

If anybody wants to try this out, I have a copr with a fedpkg build that includes these patches:

http://copr.fedoraproject.org/coprs/bochecha/pyrpkg-tests

It requires pyrpkg 1.35, which has been pushed to stable in all Fedora/EPEL branches for a while, now.

:thumbsup: code changes looks good.

:thumbsup: new download path works as advertised (tested on fedpkg repo):

  • without this pr:
    $ cd /tmp
    $ fedpkg co fedpkg
    $ cd ./fedpkg
    $ fedpkg switch-branch master
    $ fedpkg -v sources
    Creating repo object from /tmp/fedpkg
    Downloading fedpkg-1.20.tar.bz2
    Full url: http://pkgs.fedoraproject.org/repo/pkgs/fedpkg/fedpkg-1.20.tar.bz2/8ada82dca8bd21cf8cf3d47e2ae5ed14/fedpkg-1.20.tar.bz2
    ######################################################################## 100.0%
    $ rm -rf /tmp/fedpkg

  • with this pr:
    $ cd /tmp
    $ fedpkg co fedpkg
    $ cd ./fedpkg
    $ fedpkg switch-branch master
    $ fedpkg -v sources
    Creating repo object from /tmp/fedpkg
    Downloading fedpkg-1.20.tar.bz2
    Full url: http://pkgs.fedoraproject.org/repo/pkgs/fedpkg/fedpkg-1.20.tar.bz2/md5/8ada82dca8bd21cf8cf3d47e2ae5ed14/fedpkg-1.20.tar.bz2
    ######################################################################## 100.0%
    $ rm -rf /tmp/fedpkg

@ausil: if you are ok with this change please either ack and I'll merge the changes or merge it by yourself.

Just to make it clear one more time: this is not a breaking change that needs to be part of the "flag day" (when we decide to break old clients and everybody needs to upgrade)

The change in this pull request could be released to users, and both the new and old clients would continue working just fine.

@ausil: any comment?

This needs to be read from the koji config and not hardcoded. if we change the location everything would break

Again must be read from the config, I do plan to actually change this location

Other than the config deatails it looks okay

Metadata