fedpkg

#117 Use profile to load Koji configuration
Merged by cqi. Opened by cqi.
cqi/fedpkg read-koji-stg-config  into  master

Download 117.patch

In fedpkg, using the new option kojiprofile is able to load Koji
configuration from prod, stg, and specific arch profile properly.

kojiconfig is dropped.

Fix #97

Signed-off-by: Chenxiong Qi cqi@redhat.com

This requires rpkg PR#213

Job #74 fails, because rpkg master branch is used to run tests, but required changes in PR rpkg#213 is not merged yet.
Edited by lsedlar

rebased

1 new commit added

  • Simplify passing arguments when creating Command object

It's easy to fix #14 based on this PR, so include the fix in this PR.

Looks good to me, but we should wait with merging for rpkg patch to land first.

Additionally, maybe we should just remove the secondary arch stuff completely, it no longer does anything.

cc @ausil

Do we still need to keep secondary arch?

The code doesn't do anything now, the last special-cased package was removed in #121.

rebased

Rebased and removed code that handles secondary arch as discussed above.

4 new commits added

  • Remove code that handles secondary arch
  • Simplify passing arguments when creating Command object
  • Set koji profile for secondary arch immediately
  • Use profile to load Koji configuration

Ready for review again.

Looks good to me.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.