#98 fedpkg chainbuild no longer works since flag day
Closed: Fixed 5 years ago Opened 5 years ago by kevin.

On the recent flag day we changed rawhide builds to land in f26-pending tag instead of f26 tag.

This breaks chainbuilding. We should adjust fedpkg to handle this case.

[rpmbuild@localhost kde-partitionmanager]$ fedpkg chain-build kpmcore
Could not execute chainbuild: Packages in destination tag f26-pending
are not inherited bybuild tag f26-build

See: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZVLNMUTVQBJ2SX2ENMHVWI4WG4JBT6SX/

I'm not sure if this can be fixed on client side. We could remove the check for inheritance, but I have no idea if it will actually solve the problem. The package will be tagged after signing and should get into the buildroot, but will koji wait for the external entity that does the signing?

Yeah, I would imagine it would just wait until the package was signed and tagged into f26, and thus f26-build so it could go on.

indeed the koji code will wait until the build shows up in the buildroot. it would also enable chain builds to work in stable releases, instead of relying on the signing to tag in, it would rely on users to create buildroot overrides.

the issue we face with adding the -pending tag into the buildroot inheritance change is the need to restructure tags as bodhi enablement. I am not a fan of doing so as it could get messed up easily and cause issues

Cool, in that case let's just remove the inheritance check.

Any news here? Can we just do that and push out a release? Maintainers would like to be able to do chain builds again.

I just merged the pull requests and made builds and updates.

Metadata Update from @lsedlar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.