#81 fedpkg clone should set user.name and user.email
Opened 7 years ago by thm. Modified 5 years ago

It would be nice if fedpkg clone if not run with -a, could automatically set the git config options user.name and user.email locally, for the cloned repo.

The values for both can be taken from the Fedora FAS cert.


it is not possible to get the correct info from the cert. and the certs are going away next week so its really not a viable option. perhaps a better fit is to have fedora-packager-setup ask and setup thinsg globally if they are not setup

it is not possible to get the correct info from the cert. and the certs are going away next week so its really not a viable option.

Well, fedpkg at least knows the FAS username. It interacts with the packagedb iiuc, so it should be able to get any information.

perhaps a better fit is to have fedora-packager-setup ask and setup thinsg globally if they are not setup

No, this is not what I had in mind. On some machines I may be using multiple git identities, and it would be nice if fedpkg clone would set the Fedora-specific username and email for the repository it clones - to ensure the correct identity is used when committing.

@thm

What do you mean by "Fedora-specific username and email"?

IMO, setting user.name and user.email depends on everyone's preference totally. Guess values from somewhere would be good, but it could also be noisy for some others and causes they may have to restore the global setting configured by themselves or change to another one they prefer.

How about provide options user-name and user-email to clone command?

This would almost be possible already by adding user.name and user.email to clone_config option in /etc/rpkg/fedpkg.conf. Sadly, it does not handle spaces, and most people have those in their name.

@lsedlar How could clone_config help?

I doubt if this automatic set is really expected or useful for most of packagers. And it should not cover all possible use cases, for example mine. I have user.name and user.email set globally. Meanwhile, so far, there is no data source for fedpkg to query a packager's email, as there is no packagedb and PDC is sunset.

This issue has been unresolved for more than a year, and is going to be closed within a week if no further action is taken. If you feel this is in error, please contact me.
This is a cleaning process suggested by Jay Greguske. Copy of this ticket was already closed in JIRA tracker.

Log in to comment on this ticket.

Metadata