#616 RFE: check sources before running koji build
Opened by jussilehtola. Modified

fedpkg should check whether all sources are available either in the repository or in the sources file before running a koji build.


Hi @jussilehtola. Could you be more specific, please?
Where did you meet the issue?
Was it during scratch-build or regular build?
Was something missing from a specfile?
afaik scratch-build runs sources respectively srpm command before build in case srpm is missing.

Hi, this was running

$ fedpkg build

The koji build failed since I had forgotten to update the sources i.e. upload the new tarball.

fedpkg build only executes the koji build, and fedpkg passes the commit URL and other arguments. At the time the regular build command is executed, everything is already pushed in (dist-)git. So checking before(during) build doesn't make sense to me.

There is already an implemented mechanism:
1) pre-push-check
2) pre-push hook on a dist-git repo that actually executes 1) right before git push

It checks, for example:
- Source/patch not in git, sources, or additional sources
- Source file not uploaded to the lookaside cache

Mechanism is automatically enabled when the dist-git repo is cloned. But it can be disabled:

  • git push --no-verify
  • (modify/remove) the hook file .git/hooks/pre-push
  • in the fedpkg's config: skip_hooks = True (prevents creating hook file when repo is cloned)

Maybe it is disabled in your environment for some reason (in a past, it sometimes caused some troubles)?

Metadata