#584 Maybe it would be right to remove Python3.6 from tox
Closed: Fixed by amedvede. Opened by amedvede.

I have written a new command for 'fedpkg' https://pagure.io/fedpkg/pull-request/558. And there in the code I use fasjson_client to get a list of persons group. Tests always fails on python 3.6 because this version is incompatible with fasjson_clientso I don't know how to proceed.


Hi @amedvede. I am keeping py3.6 env there because of the ongoing support of epel8 which is based on Python3.6. Not sure if it is OK to drop it. Tests could hopefully be somehow decorated/customized not to require fastjson_client during py36 test.
What currently concerns me, is that fastjson_client brings other dependencies I should resolve during rpm packaging. Don't know what the list is, but in the PR I saw a few new dependencies which have to be present as rpms as well.

@onosek I can add to the py3.6 environment to ignore utils test but it still fails, because tests for cli importing fedpk.cli which are importing some utils and the error is the same. I guess the best solution is not to overcomplicate anyone's life. I can remove fasjson_client and make this test on poddlers since py36 is not used. Or I can try to find another way to get fas groups of person. But I'm for 1. solution. What do you think? The problem is that user who sends request won't be notified through creating of request stage, he will be able to see the problem just later on fedora-scm-requests tracker.

PR https://pagure.io/fedpkg/pull-request/558 is ready now it passes all tests even py36.

Metadata Update from @amedvede:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata