#529 `fedpkg import` should do some checks for the package nomenclature
Closed: Fixed 2 years ago by onosek. Opened 2 years ago by patrikp.

Related releng ticket: https://pagure.io/releng/issue/7523

According to the issue above there were two packages with very similar names, rubygem-connection_pool and rubygem-connection-pool that got created due to discrepancy in the naming conventions (an underscore) which resulted in the creation of two separate repositories in dist-git.

This could be avoided in the future if we had some self-checks while doing fedpkg import for the new packages. One proposed way to do this would be to check if the package name inside the spec file matches the package name exactly and refuse/throw an error if it does not.

This is open for further discussion.


cc: @jnsamyak @kevin @vondruch
If you have any further comments.

One proposed way to do this would be to check if the package name inside the spec file matches the package name exactly and refuse/throw an error if it does not.

This sounds as a good start (not sure if there should be some way to override this, by e.g. some --force option). However, I don't think that fedpkg import is the only place, where the check should be done, because usage of the command is just optional.

Hi, you can look whether the suggested solution fits your requirements:
https://pagure.io/rpkg/pull-request/700

Commit 13623dbf fixes this issue

Metadata Update from @onosek:
- Issue set to the milestone: 1.45

a year ago

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #700 Merged 11 months ago