Learn more about these different git repos.
Other Git URLs
This does not make any sense to me:
$ fedpkg --release f40 import rubygem-jekyll-4.3.2-3.fc40.src.rpm Could not execute import_srpm: SRPM was processed by rpmautospec (specfile "rubygem-jekyll.spec" was analyzed)
rpmautospec should have no influence on fedpkg import.
fedpkg import
Here is a reason why fedpkg is working this way:
fedpkg
https://pagure.io/rpkg/c/3087dd72e933568896b2f167bab75194482a6cd1?branch=master
If you think that this behavior is wrong, I think it would need wider discussion.
Yes, I do think it is wrong. Let me explain.
I understand the argument and it is good one. However, the import is still the best command to have everything in order, such as adding patches, removing patches and uploading the source tarballs. There is not equivalent to this.
import
Actually, my real life workflow (without autospec) is something like this:
With autospec, it will need modifications, because clog won't make sense anymore and after the import, git reset foo.spec; git checkout foo.spec will be needed. But still, the import is to add/remove the updated patches and upload source tarball.
clog
git reset foo.spec; git checkout foo.spec
While I never really used that workflow, I have another use case that my teammates want to be supported before they agree to mass convert the Python packages to %autorelease.
When they import new Fedora packages to CentOS Stream 8+9, they do:
centpkg import
The inability to import an SRPM processed by rpmautopsec makes their work harder.
That said, I think I know how to solve this issue.
First, rpmautospec needs to start generating the changelog like this:
%changelog ## START: Generated by rpmautospec * Fri Jul 21 2023 Fedora Release Engineering <releng@fedoraproject.org> - 7.2.5-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild * Mon Jul 10 2023 Python Maint <python-maint@redhat.com> - 7.2.5-7 - Rebuilt for Python 3.12 ... ## END: Generated by rpmautospec
Then, rpkg can strip the ## START: Set by rpmautospec .. ## END: Set by rpmautospec section at the beginning and the ## START: Generated by rpmautospec .. ## END: Generated by rpmautospec section (usually) at the end.
## START: Set by rpmautospec
## END: Set by rpmautospec
## START: Generated by rpmautospec
## END: Generated by rpmautospec
https://pagure.io/fedora-infra/rpmautospec/pull-request/312 is a proof of concept PR adding the comments.
https://pagure.io/rpkg/pull-request/699 is a proof of concept PR with changes in rpkg.
Commit ebb5c4b8 fixes this issue
Metadata Update from @onosek: - Issue set to the milestone: 1.45
Log in to comment on this ticket.