#513 The pre_push_check hook prevents non-packagers to push anywhere
Closed: Fixed a year ago by churchyard. Opened a year ago by churchyard.

Hello, we are in the process of sponsoring @rerickso to the packager group.

They try to submit a Fedora dist git PR. However, the newly added pre_push_check hook prevents them to push changes anywhere:

[rerickso@ctrl01 python-deepdiff]$ git remote -v
epryan-https    https://gitlab.com/epryan/fork-python-deepdiff.git (fetch)
epryan-https    https://gitlab.com/epryan/fork-python-deepdiff.git (push)
epryan-pat  https://epryan:glpat-...@gitlab.com/epryan/fork-python-deepdiff.git (fetch)
epryan-pat  https://epryan:glpat-...@gitlab.com/epryan/fork-python-deepdiff.git (push)
origin  https://src.fedoraproject.org/rpms/python-deepdiff.git (fetch)
origin  https://src.fedoraproject.org/rpms/python-deepdiff.git (push)
rerickso    ssh://rerickso@pkgs.fedoraproject.org/forks/rerickso/rpms/python-deepdiff.git (fetch)
rerickso    ssh://rerickso@pkgs.fedoraproject.org/forks/rerickso/rpms/python-deepdiff.git (push)
rerickso-https  https://src.fedoraproject.org/forks/rerickso/rpms/python-deepdiff.git (fetch)
rerickso-https  https://src.fedoraproject.org/forks/rerickso/rpms/python-deepdiff.git (push)
[rerickso@ctrl01 python-deepdiff]$ git push rerickso-https
Could not execute pre_push_check: Fail to upload files. Server returns status 403
error: failed to push some refs to 'https://src.fedoraproject.org/forks/rerickso/rpms/python-deepdiff.git'
[rerickso@ctrl01 python-deepdiff]$ git push epryan-pat
Could not execute pre_push_check: Fail to upload files. Server returns status 403
error: failed to push some refs to 'https://gitlab.com/epryan/fork-python-deepdiff.git'

The pre-push hook tries to authenticate somewhere. Probably lookaside cache? Non-packers cannot do that.


Hmm, this must be:

self.lookasidecache.remote_file_exists

I am wondering how to avoid it.
Meanwhile, non-packagers can use git push --no-verify as a workaround.

Commit 77cd608e fixes this issue

lookaside cache should be readable without logging in, is that not the case?

Metadata Update from @churchyard:
- Issue status updated to: Open (was: Closed)

a year ago

Pagure reopened this issue without me intending to do it, but the linked commit does not exist.

Metadata Update from @churchyard:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #676 Merged a year ago