fedpkg

#452 fedpkg import removes test configuration
Closed: Fixed by onosek. Opened by psss.

Closed: Fixed
Reopen Issue

After importing a fresh tmt srpm using fedpkg import I've noticed that several files were proposed to be removed:

> git status
On branch rawhide
Your branch is up to date with 'origin/rawhide'.
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
    deleted:    .fmf/version
    modified:   .gitignore
    deleted:    plans/minimal.fmf
    deleted:    plans/smoke.fmf
    deleted:    plans/upstream.fmf
    modified:   sources
    modified:   tmt.spec

These are all related to testing and should be kept. Why does fedpkg consider these as not needed anymore?

@lzachar, @fnecas, that's the issue I mentioned today.

@onosek, @lsedlar, any thoughts why these files are removed?

import deletes any files that are not included in the SRPM. There's a list of exceptions, but these files are currently not on it:
https://pagure.io/rpkg/blob/master/f/pyrpkg/init.py#_1817

Thanks for the link, @lsedlar. I've extended the list of reserved files in #585 to include fmf config files as well. Please, have a look.
Edited by psss

Commit 290859c1 fixes this issue

Metadata Update from @onosek:
- Issue set to the milestone: 1.42
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.