#44 avoid except clauses without exception specification
Opened 8 years ago by pavlix. Modified 5 years ago

Each time I am debugging any issues with fedpkg, I end up not seeing tracebacks despite -d and -v options. In most cases this is due to catch-all except clauses.

$ grep -r except:
src/fedpkg/cli.py:        except:
src/fedpkg/__init__.py:        except:
src/fedpkg/__init__.py:            except:
src/fedpkg/__init__.py:        except:
src/fedpkg/__init__.py:            except:
src/fedpkg/__main__.py:        except:
setup.py:except:

$ grep -r 'except Exception'
src/fedpkg/cli.py:        except Exception as e:
src/fedpkg/cli.py:            except Exception as e:
src/fedpkg/__init__.py:        except Exception as e:
src/fedpkg/__main__.py:    except Exception as e:

I'm pretty sure that not all of the exceptions above are re-raised or printed for the user.

Related: https://pagure.io/rpkg/issue/91


This issue has been unresolved for more than a year, and is going to be closed within a week if no further action is taken. If you feel this is in error, please contact me.
This is a cleaning process suggested by Jay Greguske. Copy of this ticket was already closed in JIRA tracker.

Log in to comment on this ticket.

Metadata