#353 Contradictory error message when repo is specified with .git extension
Closed: Fixed 4 years ago by onosek. Opened 4 years ago by mulhern.

Actions:

[mulhern@localhost ~/fedora-scm]$ rm -Rf python-into-dbus-python/
[mulhern@localhost ~/fedora-scm]$ ls -l .
total 0
[mulhern@localhost ~/fedora-scm]$ fedpkg clone python-into-dbus-python.git
Cloning into 'python-into-dbus-python'...
remote: Counting objects: 26, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 26 (delta 15), reused 0 (delta 0)
Receiving objects: 100% (26/26), done.
Resolving deltas: 100% (15/15), done.
Could not execute clone: Cmd('git') not found due to: FileNotFoundError('[Errno 2] No such file or directory: '/home/mulhern/fedora-scm/python-into-dbus-python.git': '/home/mulhern/fedora-scm/python-into-dbus-python.git'')
  cmdline: git config credential.helper /usr/bin/fedpkg gitcred
[mulhern@localhost ~/fedora-scm]$ ls -l .
total 4
drwxrwxr-x. 3 mulhern mulhern 4096 Sep  6 16:45 python-into-dbus-python

Note that the error says that it could not execute the clone, but it appears that it did.

Trying again, with some information flags set:

[mulhern@localhost ~/fedora-scm]$ rm -Rf python-into-dbus-python/
[mulhern@localhost ~/fedora-scm]$ ls -l
total 0
[mulhern@localhost ~/fedora-scm]$ fedpkg --verbose --debug clone python-into-dbus-python.git
Could not get user from .fedora.upn, falling back to default method
Cloning ssh://mulhern@pkgs.fedoraproject.org/rpms/python-into-dbus-python.git
Running: git clone ssh://mulhern@pkgs.fedoraproject.org/rpms/python-into-dbus-python.git --origin origin
Cloning into 'python-into-dbus-python'...
remote: Counting objects: 26, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 26 (delta 15), reused 0 (delta 0)
Receiving objects: 100% (26/26), done.
Resolving deltas: 100% (15/15), done.
Could not execute clone: Cmd('git') not found due to: FileNotFoundError('[Errno 2] No such file or directory: '/home/mulhern/fedora-scm/python-into-dbus-python.git': '/home/mulhern/fedora-scm/python-into-dbus-python.git'')
  cmdline: git config credential.helper /usr/bin/fedpkg gitcred
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/git/cmd.py", line 735, in execute
    **subprocess_kwargs
  File "/usr/lib64/python3.7/subprocess.py", line 775, in __init__
    restore_signals, start_new_session)
  File "/usr/lib64/python3.7/subprocess.py", line 1522, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/mulhern/fedora-scm/python-into-dbus-python.git': '/home/mulhern/fedora-scm/python-into-dbus-python.git'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/fedpkg", line 11, in <module>
    load_entry_point('fedpkg==1.37', 'console_scripts', 'fedpkg')()
  File "/usr/lib/python3.7/site-packages/fedpkg/__main__.py", line 86, in main
    sys.exit(client.args.command())
  File "/usr/lib/python3.7/site-packages/pyrpkg/cli.py", line 1864, in clone
    depth=self.args.depth)
  File "/usr/lib/python3.7/site-packages/pyrpkg/__init__.py", line 1547, in clone
    self._clone_config(conf_git, repo)
  File "/usr/lib/python3.7/site-packages/pyrpkg/__init__.py", line 1641, in _clone_config
    conf_git.config('credential.helper', ' '.join(find_me() + ['gitcred']))
  File "/usr/lib/python3.7/site-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/lib/python3.7/site-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/lib/python3.7/site-packages/git/cmd.py", line 738, in execute
    raise GitCommandNotFound(command, err)
git.exc.GitCommandNotFound: Cmd('git') not found due to: FileNotFoundError('[Errno 2] No such file or directory: '/home/mulhern/fedora-scm/python-into-dbus-python.git': '/home/mulhern/fedora-scm/python-into-dbus-python.git'')
  cmdline: git config credential.helper /usr/bin/fedpkg gitcred
[mulhern@localhost ~/fedora-scm]$ ls -l .
total 4
drwxrwxr-x. 3 mulhern mulhern 4096 Sep  6 16:53 python-into-dbus-python

Without .git extension it seems to work:

[mulhern@localhost ~/fedora-scm]$ fedpkg --verbose --debug clone python-into-dbus-python
Could not get user from .fedora.upn, falling back to default method
Cloning ssh://mulhern@pkgs.fedoraproject.org/rpms/python-into-dbus-python
Running: git clone ssh://mulhern@pkgs.fedoraproject.org/rpms/python-into-dbus-python --origin origin
Cloning into 'python-into-dbus-python'...
remote: Counting objects: 26, done.
remote: Compressing objects: 100% (24/24), done.
remote: Total 26 (delta 15), reused 0 (delta 0)
Receiving objects: 100% (26/26), done.
Resolving deltas: 100% (15/15), done.
Git-excludes patterns were added into /home/mulhern/fedora-scm/python-into-dbus-python/.git/info/exclude

Version:

Installed Packages
Name         : fedpkg
Version      : 1.37
Release      : 7.fc29
Architecture : noarch
Size         : 206 k
Source       : fedpkg-1.37-7.fc29.src.rpm
Repository   : @System
From repo    : updates
Summary      : Fedora utility for working with dist-git
URL          : https://pagure.io/fedpkg
License      : GPLv2+
Description  : Provides the fedpkg command for working with dist-git

Expectation:

It should handle the poorly chosen repo specification gracefully. It is wierd that it does clone it, but indicates failure.


Metadata Update from @onosek:
- Issue set to the milestone: 1.38

4 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #475 Merged 4 years ago