#33 fedpkg tag should refuse to work if Sources/Patches are not checked in
Opened 8 years ago by cqi. Modified 5 years ago

This was reported by wtogami in ticket

Currently as a packager you can too easily add new Sources or Patches to your .spec, successfully test it with "fedpkg local" or "fedpkg srpm", then forget to commit it to git.

fedpkg tag could error out if it detects that any files referenced by the .spec are not fully checked into git. This would both save time and help packagers to avoid errors.


It would be good to check it in fedpkg commit, and give a warning to show a list of files that are referenced by SPEC but not checked into git. For example,

fedpkg commit -m "fix a bug"
Warning: a.patch, b.patch, c.patch are referenced by SPEC, but not checked into this repo.
... [other output]

This issue has been unresolved for more than a year, and is going to be closed within a week if no further action is taken. If you feel this is in error, please contact me.
This is a cleaning process suggested by Jay Greguske. Copy of this ticket was already closed in JIRA tracker.

Log in to comment on this ticket.

Metadata