Learn more about these different git repos.
Other Git URLs
$ fedpkg srpm /usr/lib/python3.7/site-packages/fedora/client/bodhi.py:48: DeprecationWarning: fedora.client.bodhi has been deprecated. Please use bodhi.client.bindings instead. DeprecationWarning) /usr/lib/python3.7/site-packages/fedpkg/__init__.py:235: DeprecationWarning: dist() and linux_distribution() functions are deprecated in Python 3.5 runtime_os, runtime_version, _ = platform.linux_distribution()
You should probably update the bodhi API and use https://pypi.org/project/distro/ to avoid surprises in the future.
/usr/lib/python3.7/site-packages/fedora/client/bodhi.py:48: DeprecationWarning: fedora.client.bodhi has been deprecated. Please use bodhi.client.bindings instead. DeprecationWarning)
@bowlofeggs Can you please take a look at this warning?
Metadata Update from @cqi: - Issue assigned to cqi
Hi @cqi!
I wrote that warning. fedora.client.bodhi has actually now been removed from the upstream git repo:
fedora.client.bodhi
https://github.com/fedora-infra/python-fedora/commit/ad1e87c04aca6860e9273039a3a11bfd483ad56d
You should rebase your code to use Bodhi's Python REST bindings instead:
https://bodhi.fedoraproject.org/docs/python_bindings.html
Thanks @bowlofeggs. fedpkg has been using bodhi python bindings. I checked it again within rawhide (rawhide container), it is python3-fedora-0.10.0-5.fc29.noarch now, which still has the removed code and following line is in fedora/client/__init__.py
python3-fedora-0.10.0-5.fc29.noarch
fedora/client/__init__.py
from fedora.client.bodhi import BodhiClient, BodhiClientException
I created a PR #279 to use module distro, and the first warning would be disappear once newer version of python-fedora containing bowlofeggs' patch is released.
distro
As I understand it, you are not supposed to use python3-fedora for bodhi, but rather python3-bodhi directly.
@churchyard The only thing to use python3-fedora in fedpkg currently is to import AuthError from fedora.client.
AuthError
fedora.client
Commit 64f5acf fixes this issue
Metadata Update from @onosek: - Issue set to the milestone: 1.36
Login to comment on this ticket.