#103 fedpkg new-sources uploads files twice
Closed: Invalid 6 years ago Opened 7 years ago by mattia.

I'm not sure if this is a side effect of the new kerberos authentication or if it's a wanted feature: I've noticed that since flag day all files uploaded with 'fedpkg new-sources' are uploaded twice (upload and progress bar reach 100% and then restart again a second time).
This is a problem when uploading big sources. Is there a reason for that?

Thanks
Mattia


This looks like being caused by curl handling uploads very inefficiently when the server won't accept them.

Basically, curl submits the full HTTP request (doesn't wait for the HTTP 100 Continue status), only to get a 401 thrown back because it still needs to authenticate via GSSAPI.
Then curl generates the GSSAPI response, and submits this back together while resubmitting the entire request, which then goes through as expected.

In short, the problem is that it doesn't support status 100 Continue.
If it did, it would have just sent the HTTP headers, got the 401 immediately, and didn't have to upload twice.

The reason this didn't happen with TLS client cert authentication is because the authentication has already completed outside of the HTTP request.

So, update on this: turns out that Curl can deal with this just fine (and does), but we had the Expect disabled at the server end due to old configuration.
We will be enabling 100 Continue on the server-side soon.

However, due to some quirks of Apache's mod_proxy, this does not yet work as expected, but this is a server-side bug.

I have opened this as fedora-infrastructure#6139 for better visibility.

Since this can not be fixed from fedpkg side, I'll close this issue.

Metadata Update from @lsedlar:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata